(SOLVED) Help? Samus has a bug that REALLY needs fixing.

BaganSmashBros gave me his AI patch, and she's just dying to be released one last time. Before I do, I need to fix a bug that she's been plagued with for a while now: She can move and/or attack BEFORE the round officially starts. Can anybody please tell me what I need to do to fix this? I'm not sure if it's some simple piece of coding I'm looking over, or something I forgot to put in. If anyone can help, please, speak up!

Please, can anybody give me some advice?

Posts : 838 Join date : 2012-06-15 Location : Australia

Check statedef 190 (intro statedef) and see where that leads. My guess is either 190 has ctrl=1, which, should be 0 or it leads to another ctrl set which needs to be changed/removed

Oddly enough, those Ctrl states are set to "= 0" as they should be. This is really confusing to me. I don't see how it's making it to where she can move before the round actually starts. I mean, her intros and everything plays out normally, but when they're over and it's saying "Round 1... Fight!", she can move before the announcer actually says "fight".

Posts : 838 Join date : 2012-06-15 Location : Australia

What state does the intro lead to after it's done?

Moving around before the round starts is a common thing, typically found in MVC. I believe MVC:EOH utilised it.
Bear in mind that a statedef in -2 or -3 could be the cause of the problem.

Each intro state (I have an intro decider that determines which animation state to use) leads to the standing state, (state 0) with ctrl set to 0.

I may have to check the -2 and -3 sections. Would I be looking for ctrl sets, change states, or something else?

Yeah, I want this gone because I don't want her to be considered broken or cheap. The AI especially takes full advantage of this.

Posts : 5691 Join date : 2014-08-11

Hi Varia31, I like your Samus very much! (SOLVED) Help? Samus has a bug that REALLY needs fixing. 670481599

About your MUGEN issue, since you didn't post your MUGEN A.I. code, I just try to suggest a few things by merely my imagination here:

Sometimes a MUGEN A.I. author can make the A.I. happen regardless of ctrl = 0 or 1.

I think you need to find and check the A.I. activation MUGEN code (i.e. var(59) or AiLevel) in all of your StateDefs 190-19x, or even in an overridden StateDef 5900. If you found any then you might want to disable those...

Posts : 10259 Join date : 2012-05-02

borewood, i think varia fixed this as i know he released an update recently here: http://mugenmultiverse.fanbb.net/t2160p45-samus-aran-patch-31-by-varia31-released#50582

Posts : 5691 Join date : 2014-08-11

volzzilla wrote:: borewood, i think varia fixed this as i know he released an update recently here: http://mugenmultiverse.fanbb.net/t2160p45-samus-aran-patch-31-by-varia31-released#50582

Oops I am am not aware of that tongue

I downloaded his latest version yesterday and still need to find time to test it out. I tried all his previous versions which probably don't include the A.I. feature. I also want to talk with him about his XNALara experience too.

Thanks for your reminder! Like a Star @ heaven

Actually, volzzilla, I was not able to fix that bug. In my updated release, I believe I noted that the bug was still present. It isn't gamebreaking as much as it is just annoying that she can do that. If I find a way to fix that in the future, I will release a patch for the CNS.

Borewood, I'm not sure if the issue lies with the AI, as you can make Samus move before the round starts even if you're the one in control of her. Most especially if you skip the character intros.

Posts : 5691 Join date : 2014-08-11

Varia the Hunter wrote:: Actually, volzzilla, I was not able to fix that bug. In my updated release, I believe I noted that the bug was still present. It isn't gamebreaking as much as it is just annoying that she can do that. If I find a way to fix that in the future, I will release a patch for the CNS.

Borewood, I'm not sure if the issue lies with the AI, as you can make Samus move before the round starts even if you're the one in control of her. Most especially if you skip the character intros.

I downloaded your version (last file modify date was 2014-07-24), is this your latest version please?

I will try to take a closer look at her intro and A.I. issue and see whether I can pinpoint it for you.

My newest version was posted August 6th (8/6/2014).

That would be much appreciated.

Posts : 5691 Join date : 2014-08-11

Hi Varia31, in your Samus' samus.cns file, I found an overridden Stand state:

;Stand
[Statedef 0]
type = S
movetype = I
physics = S
anim = 0
ctrl = 1

I think you can remove or comment out the "ctrl = 1" line. After that the bug shall be gone.

Woooow, it never fails. It's always something simple that I overlook. lol Thank you so much. It works right now. However, when she's AI controlled, she can still move before the round starts.

Posts : 5691 Join date : 2014-08-11

Varia the Hunter wrote:: Woooow, it never fails. It's always something simple that I overlook. lol Thank you so much. It works right now. However, when she's AI controlled, she can still move before the round starts.

I tried her A.I. in both Arcade mode and Training mode. Testing by making her ChangeState from 190 to 191,192,193 intro states, yet the bug didn't happen to me. Strange..............

[EDIT]: oh I noticed this is the super-A.I.-reflex that made your Samus A.I. take place right after the "Round 1 Fight" is over, so super reflexive that it gave you an illusion that it was a bug. MUGEN1.0 AiLevel trigger can be very accurate so I think of one way in your Samus case that is to delay the A.I. activation time.

In your Samus' player.cmd file:

; A.I Commands
;-----------------------------------------------------------------------
[State -1, AIhelper]
type=changestate
trigger1=ishelper(9741)
value=9741

[State -1, AIActivate]
type = VarSet
triggerall = RoundState != 3
trigger1 = ailevel
var(0) = 1

...........................change the whole lines of MUGEN code to..............

[State -1, AIActivate]
type = VarSet
triggerall = RoundState = 2 ;A.I. should be active only during fight time
trigger1 = ailevel
trigger1 = Time >= 300 ;you can add more to this value for your liking but 300 seems to be a reasonable minimum
var(0) = 1

In your Samus' samus.cns file:

[Statedef -3]

[State -3, resetAI]
type=varset
trigger1=var(0)&&(!alive||roundstate!=2)
trigger1 = TeamSide = 2
var(0)=1
ignorehitpause=1

...........................change the whole lines of MUGEN code to..............

[State -3, resetAI]
type = null;VarSet ;you don't really need this VarSet here...
trigger1=var(0)&&(!alive||roundstate!=2)
trigger1 = TeamSide = 2
var(0)=1
ignorehitpause=1

[State -3, AIactivation]
type=helper
trigger1=!numhelper(9741)&&roundstate=2&&alive&& !var(0)
helpertype=normal
name="Samus AI"
stateno=9741
ID=9741
pos=0,0
keyctrl=1
pausemovetime=2147483647
supermovetime=2147483647
persistent=0

[State -3, TurnBackOnAI]
type = VarSet
trigger1 = var(0) = -2 && !IsHelper
trigger1 = Alive && RoundState = 2
var(0) = 1

...........................change the whole lines of MUGEN code to..............

[State -3, TurnBackOnAI]
type = null;VarSet ;you don't really need this VarSet here...
trigger1 = var(0) = -2 && !IsHelper
trigger1 = Alive && RoundState = 2
var(0) = 1